-
Notifications
You must be signed in to change notification settings - Fork 236
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add NodeRegistrationHealthy status condition to nodepool
- Loading branch information
1 parent
204531a
commit 659e4dd
Showing
10 changed files
with
361 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
pkg/controllers/nodepool/registrationhealth/controller.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| Copyright The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package registrationhealth | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/awslabs/operatorpkg/object" | ||
| "github.com/awslabs/operatorpkg/status" | ||
| "github.com/samber/lo" | ||
| "k8s.io/apimachinery/pkg/api/equality" | ||
| "k8s.io/apimachinery/pkg/api/errors" | ||
|
|
||
| "sigs.k8s.io/karpenter/pkg/operator/injection" | ||
|
|
||
| controllerruntime "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/builder" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/controller" | ||
| "sigs.k8s.io/controller-runtime/pkg/manager" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
|
|
||
| v1 "sigs.k8s.io/karpenter/pkg/apis/v1" | ||
| "sigs.k8s.io/karpenter/pkg/cloudprovider" | ||
| nodepoolutils "sigs.k8s.io/karpenter/pkg/utils/nodepool" | ||
| ) | ||
|
|
||
| // Controller for the resource | ||
| type Controller struct { | ||
| kubeClient client.Client | ||
| cloudProvider cloudprovider.CloudProvider | ||
| } | ||
|
|
||
| // NewController is a constructor | ||
| func NewController(kubeClient client.Client, cloudProvider cloudprovider.CloudProvider) *Controller { | ||
| return &Controller{ | ||
| kubeClient: kubeClient, | ||
| cloudProvider: cloudProvider, | ||
| } | ||
| } | ||
|
|
||
| func (c *Controller) Reconcile(ctx context.Context, nodePool *v1.NodePool) (reconcile.Result, error) { | ||
| ctx = injection.WithControllerName(ctx, "nodepool.healthyregistration") | ||
| stored := nodePool.DeepCopy() | ||
|
|
||
| nodeClass, ok := lo.Find(c.cloudProvider.GetSupportedNodeClasses(), func(nc status.Object) bool { | ||
| return object.GVK(nc).GroupKind() == nodePool.Spec.Template.Spec.NodeClassRef.GroupKind() | ||
| }) | ||
| if !ok { | ||
| // Ignore NodePools which aren't using a supported NodeClass. | ||
| return reconcile.Result{}, nil | ||
| } | ||
| if err := c.kubeClient.Get(ctx, client.ObjectKey{Name: nodePool.Spec.Template.Spec.NodeClassRef.Name}, nodeClass); err != nil { | ||
| return reconcile.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
|
|
||
| // If NodeClass/NodePool have been updated then NodeRegistrationHealthy = Unknown | ||
| if (nodePool.Status.NodeClassObservedGeneration != nodeClass.GetGeneration()) || | ||
| (nodePool.Generation != nodePool.StatusConditions().Get(v1.ConditionTypeNodeRegistrationHealthy).ObservedGeneration) { | ||
| nodePool.StatusConditions().SetUnknown(v1.ConditionTypeNodeRegistrationHealthy) | ||
| nodePool.Status.NodeClassObservedGeneration = nodeClass.GetGeneration() | ||
| } | ||
|
|
||
| if !equality.Semantic.DeepEqual(stored, nodePool) { | ||
| // We use client.MergeFromWithOptimisticLock because patching a list with a JSON merge patch | ||
| // can cause races due to the fact that it fully replaces the list on a change | ||
| // Here, we are updating the status condition list | ||
| if err := c.kubeClient.Status().Patch(ctx, nodePool, client.MergeFromWithOptions(stored, client.MergeFromWithOptimisticLock{})); client.IgnoreNotFound(err) != nil { | ||
| if errors.IsConflict(err) { | ||
| return reconcile.Result{Requeue: true}, nil | ||
| } | ||
| return reconcile.Result{}, err | ||
| } | ||
| } | ||
| return reconcile.Result{}, nil | ||
| } | ||
|
|
||
| func (c *Controller) Register(_ context.Context, m manager.Manager) error { | ||
| b := controllerruntime.NewControllerManagedBy(m). | ||
| Named("nodepool.healthyregistration"). | ||
| For(&v1.NodePool{}, builder.WithPredicates(nodepoolutils.IsManagedPredicateFuncs(c.cloudProvider))). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: 10}) | ||
| for _, nodeClass := range c.cloudProvider.GetSupportedNodeClasses() { | ||
| b.Watches(nodeClass, nodepoolutils.NodeClassEventHandler(c.kubeClient)) | ||
| } | ||
| return b.Complete(reconcile.AsReconciler(m.GetClient(), c)) | ||
| } |
Oops, something went wrong.