-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Allow custom configuration for apiserver host #1951
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
[CLA-PING] @doug-clarifai Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
|
I signed it! |
clientcmdapi "k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api" | ||
) | ||
|
||
// Dashboard UI default values for client configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference to Dashboard
Is your goal to point at an apiserver that kubectl doesn't know about? because even outside a kubecluster, we should be looking up the default kubeconfig context, and pulling out the apiserver from there, at least the last time i checked |
@doug-clarifai this is not required. Please check this comment #1467 (comment) |
@aledbf The comment you reference only allows a simple host name as an environment variable for the api server. The goal of this change is to allow for more flexible configurations. kubernetes/dashboard added these flags to match kubectl and proxy: kubernetes/dashboard#1256 kubernetes/dashboard#905 |
[APPROVALNOTIFIER] The Following OWNERS Files Need Approval:
We suggest the following people: |
@doug-clarifai PR needs rebase |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: doug-clarifai Assign the PR to them by writing No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Currently your system uses the kubectl_util.DefaultClientConfig() to retrieve the IP for the api-server, which may not work outside GCE in customized setups.
This PR provides optional flags to use a non-default api-server. It uses the same flags and borrows code from the kubernetes/dashboard project:
https://github.com/kubernetes/dashboard/blob/master/src/app/backend/client/apiserverclient.go
https://github.com/kubernetes/dashboard/blob/master/src/app/backend/dashboard.go#L31
This change is