Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AuthLayer conditionally #396

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Use AuthLayer conditionally #396

merged 2 commits into from
Feb 7, 2021

Conversation

kazk
Copy link
Member

@kazk kazk commented Feb 7, 2021 •
edited
Loading

Follow up on #394 (comment). AuthLayer is not necessary unless refreshable.

@kazk kazk mentioned this pull request Feb 7, 2021
Merged
@kazk kazk marked this pull request as draft February 7, 2021 12:27
@kazk kazk force-pushed the conditional-auth-layer branch from 780bf8e to ed338f1 Compare February 7, 2021 12:28
@kazk kazk marked this pull request as ready for review February 7, 2021 12:29
clux
clux approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, simpler stack for in-cluster.

@kazk kazk force-pushed the conditional-auth-layer branch from ed338f1 to 6340c9c Compare February 7, 2021 22:33
@clux clux merged commit cff35fb into kube-rs:master Feb 7, 2021
@kazk kazk deleted the conditional-auth-layer branch February 7, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazk @clux