Use HeaderValue::try_from instead for less allocation

kube-rs · Feb 10, 2021 · 6ee2b6e · 6ee2b6e
1 parent e5da843
commit 6ee2b6e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/kube/src/service/auth/layer.rs b/kube/src/service/auth/layer.rs
@@ -134,7 +134,7 @@ where
 mod tests {
     use super::*;
 
-    use std::{matches, sync::Arc};
+    use std::{convert::TryFrom, matches, sync::Arc};
 
     use chrono::{Duration, Utc};
     use futures::pin_mut;
@@ -158,7 +158,7 @@ mod tests {
             let (request, send) = handle.next_request().await.expect("service not called");
             assert_eq!(
                 request.headers().get(AUTHORIZATION).unwrap(),
-                HeaderValue::from_str(&format!("Bearer {}", TOKEN)).unwrap()
+                HeaderValue::try_from(format!("Bearer {}", TOKEN)).unwrap()
             );
             send.send_response(Response::builder().body(Body::empty()).unwrap());
         });

diff --git a/kube/src/service/auth/mod.rs b/kube/src/service/auth/mod.rs
@@ -67,7 +67,7 @@ impl RefreshableToken {
                     }
                 }
 
-                let mut value = HeaderValue::from_str(&format!("Bearer {}", &locked_data.0))
+                let mut value = HeaderValue::try_from(format!("Bearer {}", &locked_data.0))
                     .map_err(ConfigError::InvalidBearerToken)?;
                 value.set_sensitive(true);
                 Ok(value)
@@ -77,7 +77,7 @@ impl RefreshableToken {
             RefreshableToken::GcpOauth(data) => {
                 let gcp_oauth = data.lock().await;
                 let token = (*gcp_oauth).token().await?;
-                let mut value = HeaderValue::from_str(&format!("Bearer {}", &token.access_token))
+                let mut value = HeaderValue::try_from(format!("Bearer {}", &token.access_token))
                     .map_err(ConfigError::InvalidBearerToken)?;
                 value.set_sensitive(true);
                 Ok(value)

diff --git a/kube/src/service/mod.rs b/kube/src/service/mod.rs
@@ -79,13 +79,13 @@ impl TryFrom<Config> for Service {
             Authentication::None => None,
             Authentication::Basic(s) => {
                 let mut value =
-                    HeaderValue::from_str(&format!("Basic {}", &s)).map_err(ConfigError::InvalidBasicAuth)?;
+                    HeaderValue::try_from(format!("Basic {}", &s)).map_err(ConfigError::InvalidBasicAuth)?;
                 value.set_sensitive(true);
                 default_headers.insert(http::header::AUTHORIZATION, value);
                 None
             }
             Authentication::Token(s) => {
-                let mut value = HeaderValue::from_str(&format!("Bearer {}", &s))
+                let mut value = HeaderValue::try_from(format!("Bearer {}", &s))
                     .map_err(ConfigError::InvalidBearerToken)?;
                 value.set_sensitive(true);
                 default_headers.insert(http::header::AUTHORIZATION, value);