Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

W-7827284 fix from upstream, stop managing apt-transport-https #10

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

instantlinux
Copy link

@instantlinux instantlinux commented Jul 17, 2020

What does this PR do?

Cherry picks a change from the upstream: see DataDog#504; this removes management of apt-transport-https.

Motivation

Conflicts with our profile::base class which already manages this package. We want to clean up our puppet-agent runs so they aren't making "corrective changes" each time, so daily triage will pick up future unexpected changes.

Describe your test plan

Dev instances running on this branch now report no changes:

$ ssh kafka-manager-a001-ash-dev sudo puppet agent -t
Notice: Local environment: 'production' doesn't match server specified node environment 'feature_W_7827284_corrective', switching agent to 'feature_W_7827284_corrective'.
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for kafka-manager-a001-ash-dev.krxd.net
Info: Applying configuration version 'puppet-compiler-a009-ash-prod-feature_W_7827284_corrective-8bc9bb4585b'
Notice: Applied catalog in 32.56 seconds

$ ssh richbraun-dev001-ash-dev.krxd.net sudo puppet agent -t
Notice: Local environment: 'production' doesn't match server specified node environment 'feature_W_7827284_corrective', switching agent to 'feature_W_7827284_corrective'.
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for richbraun-dev001-ash-dev.krxd.net
Info: Applying configuration version 'puppet-compiler-a005-ash-prod-feature_W_7827284_corrective-8bc9bb4585b'
Notice: Applied catalog in 17.16 seconds

See also the https://puppet-ui-prod.krxd.net/#/inspect/overview dashboard for node reports.

Copy link

@dcrampton-sfdc dcrampton-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this repo seem to have no checks?

@instantlinux
Copy link
Author

Why does this repo seem to have no checks?

It was forked some time ago and we do not plan to do any dev on it. This PR just adopts a change from the upstream. Perhaps someone else can explain why we forked it.

@instantlinux instantlinux merged commit 8163db0 into krux-master Jul 17, 2020
@instantlinux instantlinux deleted the feature_W_7827284_corrective branch July 17, 2020 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants