Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/rework-package #239

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feature/rework-package #239

wants to merge 9 commits into from

Conversation

TheDadi
Copy link
Contributor

@TheDadi TheDadi commented Mar 14, 2025

chore: introduce @biomejs/biome as linter and formatter instead of prettier
chore: introduce @changesets/cli to automate publish and changelog
chore: introduce github actions for publishing to npm
chore: introduce github actions for preview publish using pkg-pr-new
chore: replace mocha with node:test
chore: updated all dependencies to latest except formidable because of node-formidable/formidable#958
chore: updated dev dependency koa-router to use @koa/router instead
chore: introduce tshy and @arethetypeswrong/cli to have esm and commonjs exports and verification that types and exports are compatible with different module resolutions (fixes: #233)
chore: introduce pnpm as package-manager

refactor: use ctx.request.rawBody instead of ctx.request.body[symbolUnparsed] for unparsed body if includeUnparsed is set
refactor: ctx.request.rawBody is also set on content-type text/* if includeUnparsed is set
refactor: if given method is not in parsedMethods do not patch koa and node with empty object anymore (fixes: #238)
refactor: changed type of ctx.req.body and ctx.request.body from any to { [key: string]: unknown } | string

feat: allow to override formidable onPart see https://github.com/node-formidable/formidable#formonpart (fixes: #172)

docs: updated README.md to reflect changes
docs: reworked examples to use typescript

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

…`prettier`

chore: introduce `@changesets/cli` to automate publish and changelog
chore: introduce github actions for publishing to npm
chore: introduce github actions for preview publish using `pkg-pr-new`
chore: replace `mocha` with `node:test`
chore: updated all dependencies to latest except `formidable` because of node-formidable/formidable#958
chore: updated dev dependency `koa-router` to use `@koa/router` instead
chore: introduce `tshy` and `@arethetypeswrong/cli` to have esm and commonjs exports and verification that types and exports are compatible with different module resolutions
chore: introduce `pnpm` as package-manager

refactor: use `ctx.request.rawBody` instead of `ctx.request.body[symbolUnparsed]` for unparsed body
refactor: `ctx.request.rawBody` is also set on content-type `text/*` if includeUnparsed is set
refactor: if given method is not in parsedMethods we do not patch koa and node with empty object anymore
refactor: changed type of `ctx.req.body` and `ctx.request.body` from `any` to `{ [key: string]: unknown } | string`

docs: updated README.md to reflect changes
docs: reworked examples to use `typescript`
@TheDadi TheDadi requested a review from jonathanong March 14, 2025 12:56
@TheDadi TheDadi force-pushed the feature/rework-package branch from 136d132 to ce5cef9 Compare March 14, 2025 17:06
Copy link

pkg-pr-new bot commented Mar 14, 2025

Open in Stackblitz

npm i https://pkg.pr.new/koajs/koa-body@239

commit: 8e8cd1d

Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 4a676a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
koa-body Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TheDadi TheDadi requested review from fengmk2 and removed request for jonathanong March 14, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant