Rocket monitoring refactor #76
Conversation
…ket-monitoring-refactor
|
These values seem to be repeating a lot when they shouldn't |
|
Same with the values in export log |
|
My graph got stuck at ymax of 1000 for some reason |
|
When the connection to telemetry closes, so does the front end window and all data is lost. Might be a later PR but I could see that happening in competition and we just lose all of our data |
The weird this is they all have unique ids, which is set when there decoded right? I assume how the telemetry service processes them holds is accidentally getting two at once. We could test with the actual BRB and see if it does that. If its not that I think it might be due to the This is how the socket context handles new packets. const handleIncomingPacket = (data: IncomingPacket) => {
if (data.type === 'data') {
const packet = data.packets.find((packet) => packet.id === data.last_id);
packetDispatch({ type: 'SET_PACKET', payload: packet });
setLogs((prevLogs) => [...prevLogs, ...data.packets]);
}
}The |
Ill add local storage so we don't have to relay fully on the socket context |
|
There needs to a read me, or some documentation for how to use it and start it up. (Eg you need and then go to webside:3000 etc open server and then open the localhost:300 in section 5 of the nontechnical installation there needs to be "sudo" in front of the last two commands. These two also need to be somewhere for quick reference for the quick use guide. Must indicate clearly that users must be in Ground-Support to run things |
|
|
|
In the "New Mission Page", could you clarify if the 'Launch Altitude' is the starting altitude or the intended apogee? |
|
Entered date 2024-10-10, displayed October 9 2025 in the mission date. Also, can you please add an easier way to update the page without having to navigate back to the previous breadcrumb? Going back means having to re select the rocket, save the configurations, and click the mission tab, which feels cluncky |
|
When editing a mission, it would be good to auto-populate the fields with current values to make it clear what information is being kept and what is being changed |
|
Need to add an "add image" or similar to the "SVG" button. Or it should show a similar message if you hover over it. |
|
No feedback when mission is made with invalid data and so not saved. (Name = 7464859, Lat = hello, Long = world, alt = purple). Please include red asterisk or other indicator of what fields are required to save. Also does not save when all field empty, so some fields are required |
|
Need to add "git clone" before the URL in the installation guide |
|
Cannot type/add text if using liquid. If there was already text, then it stays.
|
|
|
|
Most letters cannot be put in, but sometimes e can be. Not sure why. This is the same for both mass and height. It seems there can only be one e I can add a plus sign, but it crashes after. |
|
Please add a way we can not enter a lat/long/alt when creating a new mission for which we are using the transmitter. We don't want to have a rocket flight where the rocket appears to 'jump' at the beginning of it's flight because we entered the nearest known coordinates, but they aren't exactly what the transmitter says. It would be helpful for the first packet received to populate the initial values in the mission. |
|
Entering no data for height or mass will crash the Localhost:3000. Interestingly, once it resets it sets the values to 0. (this was the prior value I think). Also note to self, the name can handle 1000 characters. |
|
|
|
I cannot seem to add components. It all seems to work, but once I exit it seems to just stop existing. |
|
Should indicate the units (ie decimals vs min sec etc) |
|
Please add some test values with decimals, it is important to preserve as many decimals as possible in the displayed values to allow the most precise rocket recovery location |
|
Need to have an error message if you put in invalid data (eg location of the mission) note that words for the location (lat) does not crash the program, but it didn't save the mission. |
|
Need a way to switch from local to remote. Either manually (and need clear instructions) , or some file we can run (still need instructions) |
|
It would be great to have a single config file or runnable file to do all of the docker opening and configuration. Things to configure:
|
Comments on the date feature:Cannot click on the calendar icon to select dates visually While it does recognize that February cannot have 30 days, it doesn't give any warning and doesn't save the mission (Even with the resetting by going back and forth) |
Mission UI notes:Need to indicate units somewhere. There also should be a way to <finish thought here> The FAQ needs to be filled in. Content to put in includes:
|
|
Missions seem to be deleting themselves. I click on a mission, click connect and then begin seeing packets come in and height update, but then when I publish it, it pops up "are you sure?" and then nothing when I say yes. |
…ath instead of the vendored Also fix a bug where the site crashes when empty packets are received
Add new command line option to telemetry service to use binaries in path instead of the vendored
👀Any time during your review if you think there's anything UI changes that would be useful for LC 2024, please comment below or dm me, mock ups would be cool👀
OK OK OK
This is a big one.
Major Changes
Whats New & how to Test
1. Getting to Active Mission
You'll probably want to start by creating a new rocket
At first it will say rocket not found. To fix that go back to rocket select and click on your rocket from there.
Now you can create a new mission. You can ignore components
From here you enter an active mission by clicking on the table row
What to Test
2. Active mission
Once youre in this is what you should see
If you have any suggestions for the FAQ that'd be nice. Think on the lines of BRB hardware support and so on.
To connect you must be running the telemetry service. Which is configured in test mode atm. To do this open a terminal and navigate to
Ground-Support/services/telemetryand runcargo run.It worked if you see the following
If you get infinite new lines go to
services/telemetry/tools/decode_test.shand changepythontopython3You can
What to Test
3. Saving Data
Once you've collected enough data
look for a
successalert to popup if so you'll get redirected to the rocket detailsWhat to Test
4. Exporting Data
Go back to the missions tab and click on any published mission.
What to Test