Replace bcrypt and workFactor options to password field with generic kdf option
#9471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neric `kdf` option
emmatown
force-pushed
the
password-field-kdf-option
branch
from
85f64db to
72ddd83
Compare
dcousens
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
bcryptandworkFactoroptions in thepasswordfield with a more flexible key derivation function (kdf) interface.Rather than assume
bcrypt, the new approach supports developers to provide any key derivation function withhashandcomparemethods, making it easier to integrate alternative modern password hashing mechanisms like Argon2.The default remains for now as
bcryptjswith a work factor of 10, ensuring compatibility for existing users who do not override the default.Additionally, this pull request adds a method for retrieving the new interface from your GraphQL schema object using
getPasswordKDFrather than forcing developers to cast and understand the intricacies of the GraphQL schema object.