-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patching of LCIO event content to avoid podio crashing on inconsistencies. #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot!
Some change requests are below.
We could consider applying the patching in any case, e.g. also when writing out lcio files to ease future conversion. @tmadlener is there any specific reason why you opted to not do this in ILD?
yes, I changed this accidentally! Co-authored-by: Leonhard Reichenbach <[email protected]>
If we are being generous we could interpret it as "not changing existing behavior for LCIO output". Simply not thinking about it is probably the more honest answer here ;) (Additionally, at least for ILD the only remaining issue are the potentially missing |
Co-authored-by: Leonhard Reichenbach <[email protected]>
Tested it, and yes, it's not needed here Co-authored-by: Leonhard Reichenbach <[email protected]>
Typo Co-authored-by: Andre Sailer <[email protected]>
Remove additional space Co-authored-by: Andre Sailer <[email protected]>
Does not effect performance
BEGINRELEASENOTES
ENDRELEASENOTES
should finally fix: #34
edited-by: @Zehvogel
previous description: