Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patching of LCIO event content to avoid podio crashing on inconsistencies. #59

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

saracreates
Copy link
Contributor

@saracreates saracreates commented Jan 6, 2025

BEGINRELEASENOTES

  • Added patching of LCIO event content to avoid podio crashing on inconsistencies.

ENDRELEASENOTES

should finally fix: #34

edited-by: @Zehvogel
previous description:

Copy link
Collaborator

@Zehvogel Zehvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot!

Some change requests are below.

We could consider applying the patching in any case, e.g. also when writing out lcio files to ease future conversion. @tmadlener is there any specific reason why you opted to not do this in ILD?

yes, I changed this accidentally!

Co-authored-by: Leonhard Reichenbach <[email protected]>
@tmadlener
Copy link
Contributor

@tmadlener is there any specific reason why you opted to not do this in ILD?

If we are being generous we could interpret it as "not changing existing behavior for LCIO output". Simply not thinking about it is probably the more honest answer here ;) (Additionally, at least for ILD the only remaining issue are the potentially missing ParticleID objects, the collection contents have been fixed already by fixing all relevant processors).

saracreates and others added 2 commits January 6, 2025 16:51
Co-authored-by: Leonhard Reichenbach <[email protected]>
Tested it, and yes, it's not needed here

Co-authored-by: Leonhard Reichenbach <[email protected]>
saracreates and others added 4 commits January 7, 2025 16:36
Remove additional space

Co-authored-by: Andre Sailer <[email protected]>
Does not effect performance
@Zehvogel Zehvogel changed the title implementation of lcio -> edm4hep formating for jet clustering Add patching of LCIO event content to avoid podio crashing on inconsistencies. Jan 9, 2025
@Zehvogel Zehvogel enabled auto-merge (squash) January 9, 2025 10:19
@Zehvogel Zehvogel merged commit ae99dbe into key4hep:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jet clustering with LCFIPlus disabled
4 participants