Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse octet #1892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: parse octet #1892

wants to merge 1 commit into from

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 15, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1859

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/parser/src/lexer/string.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/datatype/str/octet/main.k

Signed-off-by: Peefy <[email protected]>
@Peefy Peefy requested review from He1pa and zong-zhe March 15, 2025 09:06
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13871417207

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 70.367%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lexer/string.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/lexer/string.rs 1 42.86%
Totals Coverage Status
Change from base Build 13760773029: -0.003%
Covered Lines: 52638
Relevant Lines: 74805

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour with null-characters in string using '\0' notation
2 participants