Base32 Module Integration for KCL Standard Library #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gitatractivo 😄 Good work! 👍👍👍 Now you need to tidy up your commits, squash them into one commit, and use |
|
LGTM, and cc @He1pa |
|
Hi @gitatractivo 😄 A test case failed, cc@He1pa, could you provide some more details to help him fix the test 😄 |
|
update the ut |
- Added BASE32 constant to STANDARD_SYSTEM_MODULES list - Implemented base32 encoding and decoding functions - Updated test files to use the correct Base32 encoding/decoding - Fixed imports in test files - Updated completion test to include base32 module - Ensured all tests pass with the new module Fixes kcl-lang#1860 Signed-off-by: Gitanshu Talwar <[email protected]>
gitatractivo
force-pushed
the
base32-stndlib
branch
from
bc8cb35 to
6a6198e
Compare
|
Hi, |
|
run failed ut locally and update snapshot by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #1860
2. What is the scope of this PR (e.g. component or file name):
kclvm/runtime/src/base32/mod.rs
kclvm/sema/src/builtin/system_module.rs
kclvm/tests/test_units/runtime/base32/test_base32.py
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Added unit tests in kclvm/tests/test_units/runtime/base32/test_base32.py that verify encoding and decoding functionality using RFC 4648 test vectors. The tests follow the same pattern as the existing Base64 tests.