Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the functions #1879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Rohanraj123
Copy link

Work in Progress!

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#1857

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa
Copy link
Contributor

He1pa commented Mar 7, 2025

you can change it to draft before you finish it

@He1pa He1pa marked this pull request as draft March 7, 2025 06:31
@Rohanraj123
Copy link
Author

Hey @He1pa , I tried to fix the function.
Func is expected to return list of hosts IPs. But it returns null because logic of network addres calculation and Ip iteration is problematic. I changed it and also tried to handle edge cases. Looking at some test cases failed I believe it returns list of IPs.
PTAL and confirm whether its a correct output then I will send the fix for other method as well.

@He1pa
Copy link
Contributor

He1pa commented Mar 12, 2025

I am not very clear about this part. Can you provide me some reference information of your code implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants