Update tslint to version 4.0.1 (#173)

package.json

@@ -22,7 +22,7 @@
     "test-only": "jest",
     "test-watch": "jest --watch",
     "remap": "remap-istanbul -i coverage/coverage-final.json -t lcovonly -o coverage/lcov.info",
-    "lint": "tslint -e src/*.ts && tslint tests/*.ts ",
+    "lint": "tslint src/*.ts && tslint tests/*.ts ",
     "build": "./node_modules/.bin/ngc -p tsconfig.json",
     "build-test": "./node_modules/.bin/ngc -p tsconfig.test.json",
     "postbuild": "npm run bundle",
@@ -63,7 +63,7 @@
     "rimraf": "^2.5.2",
     "rollup": "^0.36.3",
     "rxjs": "5.0.0-beta.12",
-    "tslint": "^3.15.1",
+    "tslint": "^4.0.1",
     "typed-graphql": "^1.0.2",
     "typescript": "~2.0.6",
     "validate-commit-msg": "^2.8.2",

src/Angular2Apollo.ts

@@ -24,7 +24,7 @@ export function defaultApolloClient(client: ApolloClient): any {
 @Injectable()
 export class Angular2Apollo {
   constructor(
-    @Inject(angularApolloClient) private client: any
+    @Inject(angularApolloClient) private client: any,
   ) {}
 
   public watchQuery(options: DeprecatedWatchQueryOptions): ApolloQueryObservable<ApolloQueryResult> {

tests/Angular2Apollo.spec.ts

@@ -235,7 +235,7 @@ describe('angular2Apollo', () => {
             expect(result).toBe('subscription');
             done();
           },
-          error(error) {
+          error() {
             done.fail('should not be called');
           },
         });

tests/_mocks.ts

@@ -4,13 +4,13 @@ import { GraphQLResult, Document } from 'graphql';
 import { print } from 'graphql-tag/printer';
 
 export function mockNetworkInterface(
-  ...mockedResponses: MockedResponse[]
+  ...mockedResponses: MockedResponse[],
 ): NetworkInterface {
   return new MockNetworkInterface(...mockedResponses);
 }
 
 export function mockBatchedNetworkInterface(
-    ...mockedResponses: MockedResponse[]
+    ...mockedResponses: MockedResponse[],
 ): BatchedNetworkInterface {
   return new MockBatchedNetworkInterface(...mockedResponses);
 }

tsconfig.json

@@ -10,7 +10,9 @@
     "lib": ["es6", "dom"],
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
-    "noImplicitAny": false
+    "noImplicitAny": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   },
   "files": [
     "typings.d.ts",

tsconfig.test.json

@@ -10,7 +10,9 @@
     "lib": ["es6", "dom"],
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
-    "noImplicitAny": false
+    "noImplicitAny": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   },
   "files": [
     "typings.d.ts",

tslint.json

@@ -18,7 +18,6 @@
     "interface-name": false,
     "jsdoc-format": true,
     "label-position": true,
-    "label-undefined": true,
     "max-line-length": [
       true,
       140
@@ -45,22 +44,19 @@
       "trace"
     ],
     "no-construct": true,
-    "no-constructor-vars": false,
     "no-debugger": true,
-    "no-duplicate-key": true,
     "no-duplicate-variable": true,
     "no-empty": true,
     "no-eval": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
     "no-null-keyword": false,
+    "no-parameter-properties": false,
     "no-require-imports": false,
     "no-shadowed-variable": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
-    "no-unreachable": true,
     "no-unused-expression": true,
-    "no-unused-variable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,
     "no-var-requires": true,
@@ -121,9 +117,6 @@
         "variable-declaration": "space"
       }
     ],
-    "use-strict": [
-      false
-    ],
     "variable-name": [
       true,
       "check-format",