Skip to content

Fix styling of slider and progress bars (alignment with other widgets, baselines) #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2015

Conversation

SylvainCorlay
Copy link
Member

Make the IntSliderand FloatProgress have width @widget-width. Now the widthattribute of Dropdown controls the complete width.

@SylvainCorlay SylvainCorlay force-pushed the IntSliderWidth branch 2 times, most recently from f23c906 to f631e5e Compare November 3, 2015 15:14
@SylvainCorlay
Copy link
Member Author

@SylvainCorlay
Copy link
Member Author

The next change should be to fix base line alignment between the horizontal [Float/Int]Progress descriptions.

@jdfreder
Copy link
Contributor

jdfreder commented Nov 4, 2015

I haven't had a chance to try the branch, but the code looks good.

@SylvainCorlay
Copy link
Member Author

This is ready. Fixed the baseline issues in the progress bars - I updated the example notebook gist.

@jdfreder
Copy link
Contributor

jdfreder commented Nov 4, 2015

Ok, I'll test it - it will be a few minutes - I need to boot another machine.

@SylvainCorlay
Copy link
Member Author

👍 of course one must build the css.

@jdfreder
Copy link
Contributor

jdfreder commented Nov 4, 2015

Ok, just tested, this looks fantastic! Great work @SylvainCorlay !

jdfreder added a commit that referenced this pull request Nov 4, 2015
Fix styling of slider (alignment with other widgets)
@jdfreder jdfreder merged commit f7fb65c into jupyter-widgets:master Nov 4, 2015
@SylvainCorlay SylvainCorlay deleted the IntSliderWidth branch November 4, 2015 17:21
@SylvainCorlay SylvainCorlay changed the title Fix styling of slider (alignment with other widgets) Fix styling of slider and progress bars (alignment with other widgets, baselines) Nov 4, 2015
@jdfreder
Copy link
Contributor

jdfreder commented Nov 4, 2015

... I think it would be a good idea to upload the alignment notebook somewhere in the repo - maybe in the examples folder? Or in the tests folder?

@SylvainCorlay
Copy link
Member Author

Yes, that is right. I should probably polish it first, and add some comments...

@jdfreder jdfreder modified the milestone: 5.0 Nov 4, 2015
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants