-
Notifications
You must be signed in to change notification settings - Fork 949
Fix styling of slider and progress bars (alignment with other widgets, baselines) #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f23c906
to
f631e5e
Compare
@jdfreder A notebook to test alignment: https://gist.github.com/SylvainCorlay/5d4632fe274840222827 |
…dth was to large.
The next change should be to fix base line alignment between the horizontal |
I haven't had a chance to try the branch, but the code looks good. |
188d00c
to
97ca9f7
Compare
This is ready. Fixed the baseline issues in the progress bars - I updated the example notebook gist. |
Ok, I'll test it - it will be a few minutes - I need to boot another machine. |
👍 of course one must build the css. |
Ok, just tested, this looks fantastic! Great work @SylvainCorlay ! |
Fix styling of slider (alignment with other widgets)
... I think it would be a good idea to upload the alignment notebook somewhere in the repo - maybe in the examples folder? Or in the tests folder? |
Yes, that is right. I should probably polish it first, and add some comments... |
Make the
IntSlider
andFloatProgress
have width@widget-width
. Now thewidth
attribute of Dropdown controls the complete width.