Remove workaround for comm_info message #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably closed the earlier PR accidentally. |
SylvainCorlay
force-pushed
the
comm_info
branch
from
e480260 to
5259811
Compare
|
Just noting that this doesn't actually require the jupyter_client patch, since the messages go directly to ipykernel. If you wanted it to work on the notebook today, you could add a backward-compat shim to define |
SylvainCorlay
force-pushed
the
comm_info
branch
3 times, most recently
from
f78a957 to
06ed09f
Compare
SylvainCorlay
force-pushed
the
comm_info
branch
4 times, most recently
from
e88f38c to
4bdce8c
Compare
SylvainCorlay
force-pushed
the
comm_info
branch
from
4bdce8c to
b6440b4
Compare
|
@jdfreder I rebased an now require notebook 4.1beta. |
| 'traitlets', | ||
| 'notebook', | ||
| 'notebook>=4.1.0b1', |
There was a problem hiding this comment.
My python packaging knowledge to too weak -- will we have to change this when 4.1.0 final is released?
There was a problem hiding this comment.
I don't think so. If you look just above, we had ipython>=4.0.0dev0 for a long time.
jdfreder
added a commit
that referenced
this pull request
Dec 11, 2015
Remove workaround for comm_info message
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on versions of jupyter_client, ipykernel and notebook including the following changes
jupyter/jupyter_client#34 merged
ipython/ipykernel#25 merged
jupyter/notebook#166, merged
This now only requires the notebook 4.1 to be released.