Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jupyter Lab 4 support #1146

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Added Jupyter Lab 4 support #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5b8dbeb
Added @lumino dependencies.
cdanielw Nov 16, 2023
a0e6a42
Removed unused @lumino dependencies.
cdanielw Nov 16, 2023
fe3fd2f
Updated webpack-cli version.
cdanielw Nov 17, 2023
2799208
Changed @lumino dependencies to v2.
cdanielw Nov 17, 2023
b50a61e
Removed @lumino dependencies.
cdanielw Nov 17, 2023
4813042
Fixed resize bug.
cdanielw Nov 17, 2023
5725f90
Updated @jupyterlab/builder version.
cdanielw Nov 17, 2023
54953a8
Updated @jupyterlab/builder dependency.
cdanielw Nov 17, 2023
5b01ded
Updated jupyterlab python version.
cdanielw Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"stream-browserify": "^3.0.0"
},
"devDependencies": {
"@jupyterlab/builder": "^3.6.0",
"@jupyterlab/builder": "^4.0.8",
"css-loader": "^3.4.2",
"eslint": "^8.23.1",
"eslint-config-prettier": "^8.5.0",
Expand All @@ -65,7 +65,7 @@
"rimraf": "^2.6.1",
"style-loader": "^1.1.2",
"webpack": "^5",
"webpack-cli": "^3.3.10"
"webpack-cli": "^5.1.4"
},
"jupyterlab": {
"extension": "src/jupyterlab-plugin",
Expand Down
2 changes: 1 addition & 1 deletion js/src/Map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ export class LeafletMapView extends utils.LeafletDOMWidgetView {

_processLuminoMessage(msg, _super) {
_super.call(this, msg);
if(!this.obj) return;
switch (msg.type) {
case 'resize':
// We set the dirty flag to true to prevent the sub-pixel error
Expand All @@ -468,7 +469,6 @@ export class LeafletMapView extends utils.LeafletDOMWidgetView {
this.dirty = true;
// If we are in a jupyter-widget tab, we get an after-show before
// this.displayed is resolved. In this case, obj is not created yet.
if(!this.obj) return;
this.obj.invalidateSize({
animate: false,
pan: true,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[build-system]
# avoid 3.6 so we don't need the rust buildchain
requires = ["jupyter_packaging~=0.12", "jupyterlab~=3.6.0", "setuptools>=40.8.0", "wheel"]
requires = ["jupyter_packaging~=0.12", "jupyterlab~=4.0.8", "setuptools>=40.8.0", "wheel"]
build-backend = "setuptools.build_meta"
Loading