Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting blog page header #1470

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Contributor

@idanidan29 idanidan29 commented Mar 6, 2025

What kind of change does this PR introduce?

This will adjust the spacing of the header in the blog page and allow users to see the writer and their information more clearly.

Issue Number:

Screenshots/videos:

image

image

Summary
This PR ensures a good layout version for both desktop and mobile. It also makes sure that the articles and their writers are always visible.

Does this PR introduce a breaking change?
no

@idanidan29 idanidan29 requested a review from a team as a code owner March 6, 2025 04:50
Copy link

github-actions bot commented Mar 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a66ae86

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (60f2d6a) to head (a66ae86).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1470   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@idanidan29 idanidan29 changed the title adding spacing adjusting blog page header Mar 6, 2025
@DhairyaMajmudar
Copy link
Member

@idanidan29 your changes in this PR moves author's details to top of the blog title which is looking a bit odd, pls. fix it and find another solution to resolve this issue.

@idanidan29
Copy link
Contributor Author

idanidan29 commented Mar 10, 2025

Hey @DhairyaMajmudar, thanks for the feedback! I did some testing and found a much better method. I believe this version works well. I tested it on multiple mobile screen sizes, and it performed correctly on all of them. I'd love to hear your thoughts on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Blog Page Heading Misplacing
2 participants