This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Feature Request: Allow radios in horizontal controlgroup to have icons. #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zontal controlgroup, allow the icons to be placed. Known problem that if you set iconpos='notext' that the buttons aren't useful and appear broken.
|
great idea. added to feature requests page for post 1.0 https://github.com/jquery/jquery-mobile/wiki/Feature-Requests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that most of the icon positioning settings display just fine in a horizontal controlgroup of radio buttons. The 'notext' positioning is fairly useless but I couldn't find an elegant way to ignore just that one iconpos value while still enabling the other positioning options.
If the data-iconpos is not set, which would be most cases, then the options display as they currently do, without any icon.
Commit messages:
If the data-iconpos attribute is manually set on the radios in a horizontal controlgroup, allow the icons to be placed. Known problem that if you set iconpos='notext' that the buttons aren't useful and appear broken.