fix(Button): hide button icons from assistive technology (carbon-desi…

…gn-system#1746) * fix(Button): hide button icons from assistive technology * chore: update snapshots
joshblack · Jan 23, 2019 · 74be9c4 · 74be9c4
1 parent 297af2e
commit 74be9c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/components/Button/Button.js b/src/components/Button/Button.js
@@ -54,6 +54,7 @@ const Button = ({
           name={Object(icon) !== icon ? icon : undefined}
           description={iconDescription}
           className={`${prefix}--btn__icon`}
+          aria-hidden="true"
         />
       );
     }
@@ -145,6 +146,7 @@ Button.propTypes = {
       svgData: PropTypes.object.isRequired,
     }),
     PropTypes.string,
+    PropTypes.node,
   ]),
 
   /**

diff --git a/src/components/DataTable/__tests__/__snapshots__/TableBatchAction-test.js.snap b/src/components/DataTable/__tests__/__snapshots__/TableBatchAction-test.js.snap
@@ -44,6 +44,7 @@ exports[`DataTable.TableBatchAction should render 1`] = `
       type="button"
     >
       <Icon
+        aria-hidden="true"
         className="bx--btn__icon"
         description="Add"
         fillRule="evenodd"
@@ -74,6 +75,7 @@ exports[`DataTable.TableBatchAction should render 1`] = `
       >
         <svg
           alt="Add"
+          aria-hidden="true"
           aria-label="Add"
           className="bx--btn__icon"
           fillRule="evenodd"