Put column numbers into Location #5375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* more readable * doesn't catch FatalErrors like OutOfMemoryError
mpollmeier
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
The general idea is good, I just had a few code style remarks. Instead of having a lengthy conversation here I simply pushed them to your branch. Hope that's ok, please take a look. Main things:
- use
Tryinstead oftry(more readable, doesn't catch FatalErrors like OutOfMemoryError) - refactor to use
valinsteaad ofvar
|
@bbrehm So this one can go in or does it need some further adjustments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts column numbers into Location, and does some minor cleanup of the code to generate Location nodes.
The old
LocationCreator.applymethod stays for a short time, in order to facilitate CS compat (i.e. it should be possible to use this without any CS adjustments). It will get thrown out in the near future, though.