Skip to content

cli: add config option for built-in pager's ruler #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

Samasaur1
Copy link
Member

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@Samasaur1 Samasaur1 requested a review from a team as a code owner April 18, 2025 02:38
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rwjblue
Copy link
Contributor

rwjblue commented Apr 18, 2025

Please excuse my ignorance here, what does the ruler do? It's not immediately obvious upon reading the docs here (though maybe if I knew the underlying tools better it would be clearer).

@Samasaur1
Copy link
Member Author

Please excuse my ignorance here, what does the ruler do? It's not immediately obvious upon reading the docs here (though maybe if I knew the underlying tools better it would be clearer).

The ruler is what streampager calls the one-line-tall gray bar at the bottom of the screen that shows your progress through the file and a couple other things (whether the pager is waiting for more data, I think?). You can always toggle it with control-R, but you couldn't configure it to start disabled even though streampager itself has an option to do so

@rwjblue
Copy link
Contributor

rwjblue commented Apr 19, 2025

Thank you!

@Samasaur1 Samasaur1 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into jj-vcs:main with commit 001801a Apr 23, 2025
28 checks passed
@Samasaur1 Samasaur1 deleted the push-rknlqlrrrnrp branch April 23, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants