Skip to content

cli: warn on startup for vimdiff used as a diff editor #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Apr 1, 2025

This is more visible than a comment. Once this is supported, I'm considering removing this entirely. I doubt many people intentionally use it, but if so, they can easily remove this warning in their config.

Another option would be to set up a file-by-file diff editing mode, for which vimdiff would be fine.

@ilyagr ilyagr force-pushed the ig/vimdiffwarn branch 2 times, most recently from a6f6478 to 4e8576c Compare April 1, 2025 21:29
@ilyagr ilyagr marked this pull request as ready for review April 1, 2025 21:29
@ilyagr ilyagr requested a review from a team as a code owner April 1, 2025 21:29
This is more visible than a comment. Once this is supported, I'm
considering removing this entirely. I doubt many people intentionally
use it, but if so, they can easily remove this warning in their config.

Another option would be to set up a file-by-file diff editing mode,
for which vimdiff would be fine.
Copy link
Member

@steadmon steadmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants