Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ls] return unresolved packages as a warning instead of an error #2511

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Lagoja
Copy link
Contributor

@Lagoja Lagoja commented Feb 11, 2025

Summary

Fixes #2510

Previously, devbox ls --outdated would error on packages that it could not resolve, like stdenv.cc.cc.lib or darwin.apple_sdk.frameworks.IOKit. This prevented devbox from checking if the rest of the packages were outdated.

This PR changes the error to a warning, so the rest of the version checks can proceed

How was it tested?

  1. Create a devbox.json
  2. Add standard packages using devbox add
  3. Add stdenv.cc.cc.lib or darwin.apple_sdk.frameworks.IOKit to the project
  4. Verify that devbox ls --outdated shows a warning for the non-versioned packages instead of an error.

@Lagoja Lagoja requested review from mikeland73 and gcurtis February 11, 2025 22:28
internal/devbox/packages.go Outdated Show resolved Hide resolved
@Lagoja Lagoja merged commit 9ec8286 into main Feb 12, 2025
29 checks passed
@Lagoja Lagoja deleted the jl/fix-outdated branch February 12, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

0.14.0-deva list outdated
2 participants