-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add projects config validation #9767
Add projects config validation #9767
Conversation
3668335
to
21f8b22
Compare
Codecov Report
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
+ Coverage 64.87% 64.88% +0.01%
==========================================
Files 288 288
Lines 12206 12210 +4
Branches 3023 3027 +4
==========================================
+ Hits 7919 7923 +4
Misses 3646 3646
Partials 641 641
Continue to review full report at Codecov.
|
9987d57
to
60c14a6
Compare
60c14a6
to
5692f6c
Compare
Hey, @SimenB anything wrong with this PR? If it needs some changes I can do it. |
No, I think this is good to go. @jeysal? My only comment is that I'd like to solve this a bit more generally than just for |
I do think we should make this validation more generic - even if we don't have the beautiful |
I think I'd like to solve this via #11963 (and then validating the output as well). Thanks for the PR though! (and help with the schema is very much welcome) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #9761.
Test plan
Unit tests added.