Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projects config validation #9767

Conversation

leonardovillela
Copy link
Contributor

Summary

Closes #9761.

Test plan

Unit tests added.

@leonardovillela
Copy link
Contributor Author

@jeysal

@leonardovillela leonardovillela force-pushed the add-projects-config-validation branch from 3668335 to 21f8b22 Compare April 5, 2020 12:02
@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #9767 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9767      +/-   ##
==========================================
+ Coverage   64.87%   64.88%   +0.01%     
==========================================
  Files         288      288              
  Lines       12206    12210       +4     
  Branches     3023     3027       +4     
==========================================
+ Hits         7919     7923       +4     
  Misses       3646     3646              
  Partials      641      641              
Impacted Files Coverage Δ
packages/jest-config/src/normalize.ts 76.92% <80.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff87b43...5692f6c. Read the comment docs.

@SimenB SimenB requested a review from jeysal April 5, 2020 12:45
@leonardovillela leonardovillela force-pushed the add-projects-config-validation branch from 9987d57 to 60c14a6 Compare April 9, 2020 22:31
@leonardovillela leonardovillela force-pushed the add-projects-config-validation branch from 60c14a6 to 5692f6c Compare April 11, 2020 08:20
@leonardovillela
Copy link
Contributor Author

Hey, @SimenB anything wrong with this PR? If it needs some changes I can do it.

@SimenB
Copy link
Member

SimenB commented Apr 26, 2020

No, I think this is good to go. @jeysal?

My only comment is that I'd like to solve this a bit more generally than just for testSequencer, but I'm not sure how that would look so we can definitely land this for now 👍

@jeysal
Copy link
Contributor

jeysal commented Apr 28, 2020

I do think we should make this validation more generic - even if we don't have the beautiful io-tsish config validation mechanism we'd like at the moment, I think this is rather easily achievable. We have groupOptions inside jest-config - we can apply that to the project entry, take the projectConfig from the result, and throw if the globalConfig from the result contains anything.

@SimenB
Copy link
Member

SimenB commented Feb 24, 2022

I think I'd like to solve this via #11963 (and then validating the output as well). Thanks for the PR though! (and help with the schema is very much welcome)

@SimenB SimenB closed this Feb 24, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSequencer config silently ignored in projects
5 participants