Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filename for obsolete snapshot file #8665

Merged
merged 13 commits into from
Jul 26, 2019
Merged

add filename for obsolete snapshot file #8665

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e545e42
add a reproduction to my issue
ndelangen Jul 9, 2019
bdee8ed
ADD filesRemovedList property to snapshotSummary & display this in th…
ndelangen Jul 9, 2019
e4857dc
ADD tests
ndelangen Jul 9, 2019
b680151
ADD to changelog
ndelangen Jul 9, 2019
3a450de
FIX unit tests & add a null-check before getting the array length of …
ndelangen Jul 9, 2019
d2ff007
chore: run with default reporter to debug ci
SimenB Jul 9, 2019
895a8d8
simplify cleanup function of jest-snapshot
ndelangen Jul 10, 2019
ae70ff8
Merge branch 'master' into ndelangen/add-filename-for-obsolete-snapsh…
SimenB Jul 26, 2019
3360711
chore: use filter over reduce
SimenB Jul 26, 2019
5427854
chore: only report obsolete snapshots of non-ignored tests
SimenB Jul 26, 2019
d25b005
Revert "chore: run with default reporter to debug ci"
SimenB Jul 26, 2019
1cde9a3
Update CHANGELOG.md
SimenB Jul 26, 2019
930400f
get rid of unnecessary array spread
jeysal Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: use filter over reduce
  • Loading branch information
@SimenB
SimenB committed Jul 26, 2019
commit 3360711c66c7b31b1e2abc0ddb90a47d069cdcc5
8 changes: 4 additions & 4 deletions packages/jest-snapshot/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,16 @@ const cleanup = (
} => {
const pattern = '\\.' + EXTENSION + '$';
const files = hasteFS.matchFiles(pattern);
const list = files.reduce<Array<string>>((acc, snapshotFile) => {
const list = files.filter(snapshotFile => {
if (!fileExists(snapshotResolver.resolveTestPath(snapshotFile), hasteFS)) {
if (update === 'all') {
fs.unlinkSync(snapshotFile);
}
return [...acc, snapshotFile];
return true;
}

return acc;
}, []);
return false;
});

return {
filesRemoved: list.length,
Expand Down