Watch mode number of CPUs & documentation. #8211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
approved these changes
Mar 25, 2019
cpojer
reviewed
Mar 25, 2019
| @@ -31,7 +31,8 @@ export default function getMaxWorkers( | |||
|
|
|||
| return parsed > 0 ? parsed : 1; | |||
| } else { | |||
| // In watch mode, Jest should be unobtrusive and not take all available CPU. | |||
There was a problem hiding this comment.
"[…] not use all available CPUs."?
Codecov Report
@@ Coverage Diff @@
## master #8211 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 265 265
Lines 10534 10534
Branches 2555 2556 +1
=======================================
Hits 6564 6564
Misses 3387 3387
Partials 583 583
Continue to review full report at Codecov.
|
SimenB
approved these changes
Mar 25, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert change to number of CPUs and add docs to resolve @cpojer comment:
#8201 (comment)
Benchmarked Jest non-e2e test performance for this branch from 14.973s to 16.504s, which is still a massive win over the original 23.234s and probably points to further optimizations being possible since I'd hope that giving it 5 extra CPUs would do more for the performance.
Test plan