docs: Expand changelog entry for #5367 #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5719 +/- ##
=======================================
Coverage 63.66% 63.66%
=======================================
Files 216 216
Lines 7921 7921
Branches 4 3 -1
=======================================
Hits 5043 5043
Misses 2877 2877
Partials 1 1Continue to review full report at Codecov.
|
|
@eps1lon mind opening up a separate issue (or even PR :D) for the future work you note? I agree that it seems like the right thing to do |
|
@SimenB Will take a look at it, |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes from #5367 also affected
toMatchObject. I added some test cases to proof that behavior and expanded the changelog entry.Test plan
Future work
It is probably a good idea to show class instance properties when the objects did not match. Currently the diff only shows properties for which
.hasOwnPropertyis true.https://github.com/facebook/jest/blob/74bf072e43789bf5bcfe85f2aa9492905c4d2e9a/packages/expect/src/utils.js#L93-L97