Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-config): allow to use .js files in presets (#3564) #4741

Closed
wants to merge 1 commit into from

Conversation

robin-drexler
Copy link
Contributor

Summary
Allows to use a jest-preset.js instead of a jest-preset.json in presets, making it as flexible as jest.config.js and e.g. makes it possible to set config based on current environment. (#3564 (comment))
The .json file takes precedence.

Test plan
Added a unit test and tried it in a local project.
I can push that project and the necessary shell commands if necessary.
I'd like to know first, if you'd be interested at all in adding such a feature.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@milesj
Copy link

milesj commented Oct 21, 2017

I started working on this but haven't had time to finish it: #4499

@robin-drexler
Copy link
Contributor Author

Ooops, totally missed your PR, sorry. I probably only searched in issues and not pull requests.

I'll close my PR in favor of yours.
Thanks for letting me know, @milesj

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants