Tighten type definition of Module

jestjs · Oct 7, 2017 · baadeae · baadeae
1 parent 97a74bb
commit baadeae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/jest-runtime/src/__tests__/runtime_require_module.test.js b/packages/jest-runtime/src/__tests__/runtime_require_module.test.js
@@ -33,11 +33,11 @@ describe('Runtime requireModule', () => {
         'RegularModule',
       );
       expect(Object.keys(exports.module)).toEqual([
+        'children',
         'exports',
         'filename',
         'id',
         'loaded',
-        'children',
         'parent',
         'paths',
       ]);
@@ -50,6 +50,7 @@ describe('Runtime requireModule', () => {
         'RegularModule',
       );
       expect(exports.parent).toEqual({
+        children: [],
         exports: {},
         filename: 'mock.js',
         id: 'mockParent',

diff --git a/packages/jest-runtime/src/index.js b/packages/jest-runtime/src/index.js
@@ -29,14 +29,14 @@ import {run as cilRun} from './cli';
 import {options as cliOptions} from './cli/args';
 
 type Module = {|
-  children?: Array<any>,
+  children: Array<Module>,
   exports: any,
   filename: string,
   id: string,
   loaded: boolean,
   parent?: Module,
   paths?: Array<Path>,
-  require?: Function,
+  require?: (id: string) => any,
 |};
 
 type HasteMapOptions = {|
@@ -77,6 +77,7 @@ const getModuleNameMapper = (config: ProjectConfig) => {
 };
 
 const mockParentModule: Module = {
+  children: [],
   exports: {},
   filename: 'mock.js',
   id: 'mockParent',
@@ -318,6 +319,7 @@ class Runtime {
       // circular dependencies that may arise while evaluating the module can
       // be satisfied.
       const localModule: Module = {
+        children: [],
         exports: {},
         filename: modulePath,
         id: modulePath,
@@ -391,6 +393,7 @@ class Runtime {
 
     if (manualMock) {
       const localModule: Module = {
+        children: [],
         exports: {},
         filename: modulePath,
         id: modulePath,