Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bandh): asus cards / out of stock check added #1670

Merged
merged 7 commits into from
Jan 14, 2021
Merged

fix(bandh): asus cards / out of stock check added #1670

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed81023
Bandh Changes:
wofnull Jan 13, 2021
08d40ac
Added ASUS 3090 cards to bandh, that are currently missing
wofnull Jan 13, 2021
e14efff
Bandh added Asus 3070 cards
wofnull Jan 13, 2021
559b33f
Added Asus 3060ti Cards to bandh
wofnull Jan 13, 2021
1362609
Added out of stock check for Bandh, as inStock check seems not to wor…
wofnull Jan 13, 2021
fe4b91d
Github build-and-lint clenaup
wofnull Jan 13, 2021
e0cac75
Merge branch 'main' into bandh_patch
jef Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/reference/filter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,21 +170,21 @@ Used with the `SHOW_ONLY_BRANDS` and `SHOW_ONLY_MODELS` variables.
| Brand | Model |
|:---:|---|
| `amd` | `5600x`, `5800x`, `5900x`, `5950x`, `amd reference` |
| `asus` | `crosshair viii`, `dual`, `dual oc`, `strix`, `strix oc`, `tuf`, `tuf oc` |
| `asus` | `crosshair viii`, `dual`, `dual oc`, `ekwb`, `ko`, `ko oc`, `strix`, `strix oc`, `strix white`, `tuf`, `tuf oc` |
| `corsair` | `750 platinum`, `600 platinum` |
| `colorful` | `igame advanced oc`, `igame vulcan oc` |
| `evga` | `ftw3`, `ftw3 ultra`, `ftw3 ultra hydro copper`, `xc3`, `xc gaming`, `xc3 black`, `xc3 ultra` |
| `evga` | `ftw3`, `ftw3 black`, `ftw3 ultra`, `ftw3 ultra hydro copper`, `xc3`, `xc gaming`, `xc black`, `xc3 black`, `xc3 ultra` |
| `gainward` | `phantom gs`, `phoenix`, `phoenix gs`, `phoenix gs oc` |
| `gigabyte` | `aorus master`, `aorus xtreme`, `aorus xtreme waterforce`, `aorus xtreme waterforce wb`, `eagle`, `eagle oc`, `gaming`, `gaming oc`, `turbo`, `vision`, `vision oc` |
| `gigabyte` | `aorus master`, `aorus xtreme`, `aorus xtreme waterforce`, `aorus xtreme waterforce wb`, `eagle`, `eagle oc`, `gaming`, `gaming oc`, `gaming oc pro`, `turbo`, `vision`, `vision oc` |
| `galax` | `sg`, `sg oc` |
| `inno3d` | `gaming x3`, `ichill x3`, `ichill x4`, `ichill frostbite`, `twin x2 oc` |
| `inno3d` | `gaming x3`, `ghost oc`, `ichill x3`, `ichill x4`, `ichill frostbite`, `twin x2`, `twin x2 oc` |
| `kfa2` | `sg`, `sg oc` |
| `leadtek` | `hurricane` |
| `microsoft` | `xbox series x`, `xbox series s` |
| `msi` | `gaming x trio`, `suprim x`, `ventus 2x oc`, `ventus 3x`, `ventus 3x oc` |
| `nvidia` | `founders edition` |
| `palit` | `gamerock oc`, `gaming pro`, `gaming pro oc` |
| `pny` | `dual fan`, `xlr8 revel`, `xlr8 uprising` |
| `palit` | `dual oc`, `gamerock oc`, `gaming pro`, `gaming pro oc` |
| `pny` | `dual fan`, `uprising`, `xlr8 gaming`, `xlr8 revel`, `xlr8 uprising` |
| `sony` | `ps5 console`, `ps5 digital` |
| `xfx` | `merc`, `amd reference` |
| `zotac` | `amp holo`, `amp extreme holo`, `trinity`, `trinity oc`, `twin edge`, `twin edge oc` |
Expand Down
109 changes: 102 additions & 7 deletions src/store/model/bandh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ export const BAndH: Store = {
maxPrice: {
container: 'div[data-selenium="pricingPrice"]',
euroFormat: false
},
outOfStock: {
container: 'button[data-selenium="notifyAvailabilityButton"]',
text: ['notify when available']
}
},
links: [
Expand Down Expand Up @@ -42,6 +46,41 @@ export const BAndH: Store = {
url:
'https://www.bhphotovideo.com/c/product/1602756-REG/asus_strixrtx3070o8_rog_strix_geforce_rtx.html'
},
{
brand: 'asus',
model: 'dual oc',
series: '3070',
url:
'https://www.bhphotovideo.com/c/product/1603974-REG/asus_dualrtx3070o8g_dual_geforce_rtx_3070.html'
},
{
brand: 'asus',
model: 'ko oc',
series: '3070',
url:
'https://www.bhphotovideo.com/c/product/1606745-REG/asus_90yv0fq2_m0aa00_ko_nvidia_geforce_rtx.html'
},
{
brand: 'asus',
model: 'tuf oc',
series: '3070',
url:
'https://www.bhphotovideo.com/c/product/1606746-REG/asus_tuf_rtx3070_o8g_gaming_tuf_gaming_nvidia_geforce.html'
},
{
brand: 'asus',
model: 'ekwb',
series: '3070',
url:
'https://www.bhphotovideo.com/c/product/1614305-REG/asus_rtx3070_8g_ek_ekwb_geforce_rtx_3070.html'
},
{
brand: 'asus',
model: 'strix white',
series: '3070',
url:
'https://www.bhphotovideo.com/c/product/1614300-REG/asus_rog_strix_rtx3070_o8g_white_rog_strix_geforce_rtx.html'
},
// TUF was removed from BH, not sure why so commenting out listing for now
// {
// brand: 'asus',
Expand All @@ -63,13 +102,48 @@ export const BAndH: Store = {
url:
'https://www.bhphotovideo.com/c/product/1592969-REG/zotac_zt_a30800d_10p_gaming_geforce_rtx_3080.html'
},
// TUF was removed from BH, not sure why so commenting out listing for now
// {
// brand: 'asus',
// model: 'tuf oc',
// series: '3080',
// url: 'https://www.bhphotovideo.com/c/product/1593650-REG/asus_tuf_rtx3080_o10g_gaming_tuf_gaming_geforce_rtx.html'
// },
{
brand: 'asus',
model: 'tuf oc',
series: '3080',
url:
'https://www.bhphotovideo.com/c/product/1593650-REG/asus_tuf_rtx3080_o10g_gaming_tuf_gaming_geforce_rtx.html'
},
{
brand: 'asus',
model: 'strix oc',
series: '3080',
url:
'https://www.bhphotovideo.com/c/product/1603617-REG/asus_rog_strix_rtx3080_o10g_gaming_rog_strix_geforce_rtx.html'
},
{
brand: 'asus',
model: 'strix white',
series: '3080',
url:
'https://www.bhphotovideo.com/c/product/1614301-REG/asus_rog_strix_rtx3080_o10g_white_rog_strix_geforce_rtx.html'
},
{
brand: 'asus',
model: 'ekwb',
series: '3080',
url:
'https://www.bhphotovideo.com/c/product/1614303-REG/asus_rtx3080_10g_ek_ekwb_geforce_rtx_3080.html'
},
{
brand: 'asus',
model: 'ko oc',
series: '3060ti',
url:
'https://www.bhphotovideo.com/c/product/1609756-REG/asus_ko_rtx3060ti_o8g_gaming_ko_geforce_rtx_3060.html'
},
{
brand: 'asus',
model: 'tuf oc',
series: '3060ti',
url:
'https://www.bhphotovideo.com/c/product/1607025-REG/asus_tuf_rtx3060ti_o8g_gaming_geforce_rtx_3060_ti.html'
},
{
brand: 'gigabyte',
model: 'eagle oc',
Expand Down Expand Up @@ -197,6 +271,27 @@ export const BAndH: Store = {
url:
'https://www.bhphotovideo.com/c/product/1594451-REG/asus_90yv0fd1_m0am00_tuf_gaming_geforce_rtx.html'
},
{
brand: 'asus',
model: 'ekwb',
series: '3090',
url:
'https://www.bhphotovideo.com/c/product/1607043-REG/asus_rtx3090_24g_ek_geforce_rtx_3090_24g.html'
},
{
brand: 'asus',
model: 'strix',
series: '3090',
url:
'https://www.bhphotovideo.com/c/product/1601764-REG/asus_rog_strix_rtx3090_o24g_gaming_rog_strix_geforce_rtx.html'
},
{
brand: 'asus',
model: 'strix white',
series: '3090',
url:
'https://www.bhphotovideo.com/c/product/1614302-REG/asus_rog_strix_rtx3090_o24g_white_rog_strix_geforce_rtx.html'
},
{
brand: 'amd',
model: '5950x',
Expand Down
5 changes: 5 additions & 0 deletions src/store/model/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export type Model =
| 'ekwb'
| 'founders edition'
| 'ftw3'
| 'ftw3 black'
| 'ftw3 ultra'
| 'ftw3 ultra hydro copper'
| 'gamerock oc'
Expand All @@ -93,6 +94,7 @@ export type Model =
| 'gaming trio'
| 'gaming x trio'
| 'gaming x3'
| 'ghost oc'
| 'suprim x'
| 'suprim'
| 'gaming'
Expand Down Expand Up @@ -125,6 +127,7 @@ export type Model =
| 'strix lc'
| 'strix oc'
| 'strix'
| 'strix white'
| 'taichi'
| 'trinity oc'
| 'trinity'
Expand All @@ -144,11 +147,13 @@ export type Model =
| 'vision'
| 'xbox series s'
| 'xbox series x'
| 'xc black'
| 'xc gaming'
| 'xc3 black'
| 'xc3 ultra'
| 'xc3'
| 'xlr8 epic x'
| 'xlr8 gaming'
| 'xlr8 revel'
| 'xlr8 uprising';

Expand Down