Allow Specification of a New File Mode in scp.put #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using this library to transfer files to embedded devices running dropbear. By default, this doesn't support SFTP, which I would prefer to keep that way in order to keep things small and simple. However, I do need to control the file modes on the target. And since the SCP protocol allows specification of a mode, I thought extending this library would be more elegant than following up the scp.put command with an ssh.exec_command('chmod ...') command.
|
This is a good idea! Could you add a little test to |
|
Maybe chmod should be a mask, instead of overriding the file's mode? 🤔 |
|
Seems a duplicate of #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this library to transfer files to embedded devices running dropbear. By default, this doesn't support SFTP, which I would prefer to keep that way in order to keep things small and simple. However, I do need to control the file modes on the target. And since the SCP protocol allows specification of a mode, I thought extending this library would be more elegant than following up the scp.put command with an ssh.exec_command('chmod ...') command.