Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #167

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Update README.rst #167

merged 1 commit into from
Oct 16, 2020

Conversation

ajasir
Copy link
Contributor

@ajasir ajasir commented Oct 16, 2020

Added code snippet in order to incorporate defender lockout mechanism with the combination of django-rest-auth and django rest framework.

Added code snippet in order to incorporate defender lockout mechanism with the combination of django-rest-auth module and djangorestframework.
Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@ajasir ajasir requested a review from kencochrane October 16, 2020 17:26
@kencochrane
Copy link
Collaborator

It looks like it is failing on Travis for something unrelated not sure why, I haven't had a chance to look into it yet.

@kencochrane
Copy link
Collaborator

kencochrane commented Oct 16, 2020

Ok I think I found the issue, looks like a bad version on Pypi for django-redis-cache

sebleier/django-redis-cache#196

Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kencochrane kencochrane merged commit 0ad3690 into jazzband:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants