Enhance SSPI function converage and bugfix SecBufferDesc #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalyser_fix_version The ant-elfanalyser helper ant task should be compiled with source/target version
When native interface is changed the files under lib/native are invalidated and replace with out-of-date.jar. This will cause the ELFAnalyserTest to fail. It is expected, that the dist files will be more stable than the lib/native files.
…ariant Add support for IEnumVariant
…es-get-env Get JNIEnv pointer and support direct mapping with OPTION_ALLOW_OBJECTS
Direct Mapping for boolean arrays
Update URL for JNAerator
The ELFAnalyser analyses the java binary to determine, whether the hardfloat/softfloat flags are set. This causes issues if a security manager is in place and limits file accessibility. The JNA code base needs read access on the /proc/self/exe symlink and the referenced binary. This change reduces the cases where the executing binary is read. On platforms, that don't need it, the detection step is skipped. Close: java-native-access#825
…e_security_manager_exposure Only analyse binary to determine hardfloat vs. softfloat on arm
- MonitorFromPoint takes a structure, not a reference to a structure, so function definition was wrong - The last to "KnownFolters" don't resolve on Win10
(unmappable character for encoding ascii)
…nittests Fix unittests (IShellFolderTest#testEnumObjects) still fails on amd64)
…ncoding Compilation of unittests fails in debian squeeze chroot
(Re-)Bind SSPI functions: - InitializeSecurityContext - AcceptSecurityContext - QueryCredentialsAttributes - QuerySecurityPackageInfo - EncryptMessage - DecryptMessage - MakeSignature - VerifySignature Add binding for SEC_WINNT_AUTH_IDENTITY structure. The existing SecBufferDesc binding is replaced as the binding does not correctly map the native structure. The pBuffers member is not an array of SecBuffer.ByReference, but a pointer to an array of SecBuffer's. This manifests when more than one buffer is specified. The SecBufferDesc structure is the literal transliteration of the native C header. In addition a ManagedSecBufferDesc was introduced, that allows easy access to its members, as long, as the structure is managed from the java side. Closes: java-native-access#843
|
@dblock @twall Please have another look at this. Don't be irritated by the number of commits - I merged master into I'm still not convinced that breaking API is a good idea, I just think that having this out-of-tree is even worse. I'd have preferred #839. |
|
Lets get master -> jna-5.0.0 merged first? Maybe just go for it? I can look at the rest later. |
|
9771b59 looks good to me! I would merge it to JNA master right now, too ;) |
|
Merged - thank you for looking into this. |
|
I am glad these important fixes are making it into JNA, thanks for hanging on @matthiasblaesing, great work! Say hi if ever in NYC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re-)Bind SSPI functions:
Add binding for SEC_WINNT_AUTH_IDENTITY structure.
The existing SecBufferDesc binding is replaced as the binding does
not correctly map the native structure. The pBuffers member is not
an array of SecBuffer.ByReference, but a pointer to an array of
SecBuffer's. This manifests when more than one buffer is specified.
The SecBufferDesc structure is the literal transliteration of the
native C header. In addition a ManagedSecBufferDesc was introduced, that
allows easy access to its members, as long, as the structure is managed
from the java side.
Closes: #843