[531] Fix stdcall callback calling convention #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| cbstruct = peer != 0 ? new Pointer(peer) : null; | ||
| allocatedMemory.put(this, new WeakReference(this)); |
There was a problem hiding this comment.
For some reason this code was previously only tracking direct-mapped callbacks. I don't think that was intentional, so moving it here to consistently track all allocated callback structures.
…ging interface is present
twall
force-pushed
the
531-callback-cc-from-options
branch
from
56c7400 to
f2c2b4e
Compare
twall
added a commit
that referenced
this pull request
Dec 4, 2015
…options [531] Fix stdcall callback calling convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that any calling convention set in library options gets propagated to callbacks.
Also includes non-direct callbacks in forced memory reclamation.
Fixes issue #531