Refactor tests #1087
Merged
Refactor tests #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor handleSubmit, FormikActions, FormikComputedProps tests
Finish Formik test suite refactor
Cleanup Formik test suite
Refactor withFormik test suite
Refactor and unify Field / FastField test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to safely finish #1005 (v2) and #1063, we really need to make sure the test suite is sound. It's been kind of rotting since 0.8 -> 0.9 when we introduced the render prop. Prior to that, enzyme was the only way to test the hoc.
Goals
handleSubmit,handleReset,handleBlur, andhandleChangewithFormik()and<Formik />(with factory)<Field>and<FastField>(with factory)