-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bevy 0.14.0-rc.* & upgrade egui-gizmo dependency #107
Conversation
but a bit buggy
accidentally committed changes
and added documentation here and there
to avoid panics
Addresses Bevy [9202](bevyengine/bevy#9202)
Addresses Bevy [13317](bevyengine/bevy#13317)
Addresses Bevy[9202](bevyengine/bevy#9202)
Addresses Bevy [12163](bevyengine/bevy#12163)
Addresses Bevy [12715](bevyengine/bevy#12715)
Or maybe this PR can be more self-contained and doesn't have to include the egui-gizmo change 🤔 |
bevy 14 is out now so you can probs update those git deps to be actual versioned deps |
Oops, just wanted to rename the branch to @alphastrata The Bevy dependency has been upgraded to the official version in #110, but looks like some of the dependencies still need to get their upgrades pushed to crates. |
This PR allows bevy_editor_pls to be used with the newest Bevy 0.14 rc (currently at least rc.3), and is based on top of #106 by @ActuallyHappening .
Before anything happens to this, we should probably first:
transform_gizmo_bevy
to updateegui
version #106 merged & rebase this PR on topConcretely, this implements the following migration steps:
App
andSubApp
internals for better separation bevyengine/bevy#9202 : Use app.world_mut() or .world() instead of .worldApp
andSubApp
internals for better separation bevyengine/bevy#9202 : Match app.get_sub_app as Option instead of ResultLegacyColor
tobevy_color::Color
bevyengine/bevy#12163 : Use Color::srgb* instead of Color::rgb*