Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix subdomain examples in CHANGELOG #7240

Merged
merged 4 commits into from
Apr 29, 2020
Merged

docs: fix subdomain examples in CHANGELOG #7240

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6616295
docs: fix subdomain examples in CHANGELOG
lidel Apr 28, 2020
ba53db7
chore: undo a typo
lidel Apr 28, 2020
c95a723
docs: fix ENS path
lidel Apr 28, 2020
f998d53
docs: clarify ENS and DNSLink
lidel Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,13 @@ In addition to a bunch of bug fixes, we've made two improvements to the gateway.

You can play with both of these features by visiting:

> http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.io/
> http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.localhost:8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use dweb.link (see #7240). That way, this works for users without IPFS installed.

Copy link
Member Author

@lidel lidel Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien Listings are still broken there (imposible to go into sublinks when on subdomain gateway), that is why I explicitly did not use it as an example.

We can switch to dweb.link when its actually uses 0.5 for subdomain feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.dweb.link/ipfs/bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm/quick-start → error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix requires https://github.com/protocol/bifrost-infra/pull/573 to land


##### Subdomain Gateway

First up, we've changed how URLs in the IPFS gateway work for better browser
security. The gateway will now redirect from
`http://localhost:5001/ipfs/CID/...` to `http://CID.ipfs.localhost:5001/...` by
`http://localhost:8080/ipfs/CID/...` to `http://CID.ipfs.localhost:8080/...` by
default. This:

* Ensures that every dapp gets its own browser origin.
Expand All @@ -246,7 +246,7 @@ Note: cURL doesn't follow redirects by default. To avoid breaking cURL and other

The second feature is a face-lift to the directory listing theme and color palette.

> http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.io/
> http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.localhost:8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


#### IPNS

Expand Down Expand Up @@ -4997,7 +4997,7 @@ There have been no changes since the last release candidate 0.4.3-rc4. \o/
### 0.4.3-rc4 - 2016-09-09

This release candidate fixes issues in Bitswap and the `ipfs add` command, and improves testing.
We plan for this to be the last release candidate before the release of go-ipfs v0.4.3.
We plan for this tohttp://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.localhost:8080 be the last release candidate before the release of go-ipfs v0.4.3.
lidel marked this conversation as resolved.
Show resolved Hide resolved

With this release candidate, we're also moving go-ipfs to Go 1.7, which we expect will yield improvements in runtime performance, memory usage, build time and size of the release binaries.

Expand Down