Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-ipfs-cmds to 0.4.13 #4463

Closed
wants to merge 1 commit into from
Closed

update go-ipfs-cmds to 0.4.13 #4463

wants to merge 1 commit into from

Conversation

keks
Copy link
Contributor

@keks keks commented Dec 7, 2017

Hopefully fixes #4360 and #4436.

@keks keks self-assigned this Dec 7, 2017
@ghost ghost added the status/in-progress In progress label Dec 7, 2017
@keks keks force-pushed the fix/add-panic-ctrl-d-2 branch from f074db5 to 278bd81 Compare December 7, 2017 13:03
@keks
Copy link
Contributor Author

keks commented Dec 7, 2017

So sometimes this one happens:

*** test/sharness/t0065-active-requests.sh ***

[snip]

ok 4 - api file shows up

[snip]

expecting success: 
  kill $LOGPID
  go-sleep 0.5s
  kill $LOGPID
  wait $LOGPID || true
Error: request canceled
./t0065-active-requests.sh: 4: kill: No such process
ok 13 - kill log cmd
expecting success: 
  ipfs diag cmds > cmd_out3
Error: api not running
not ok 14 - long running command inactive
#	
#	  ipfs diag cmds > cmd_out3
#	
expecting success: 
  grep "log/tail" cmd_out3 | grep "false"
not ok 15 - command shows up as inactive
#	
#	  grep "log/tail" cmd_out3 | grep "false"
#	
expecting success: 
    kill -0 $IPFS_PID
  
./t0065-active-requests.sh: 2: kill: No such process
not ok 16 - 'ipfs daemon' is still running
#	
#	    kill -0 $IPFS_PID
#	  
expecting success: 
    test_kill_repeat_10_sec $IPFS_PID
  
./t0065-active-requests.sh: 263: kill: No such process
ok 17 - 'ipfs daemon' can be killed
# failed 3 among 17 test(s)
1..17

The reason is a data race in the http ResponseEmitter, working on it...

@whyrusleeping
Copy link
Member

@keks does this supercede #4455 ?

@Stebalien
Copy link
Member

@whyrusleeping yes. Waiting on ipfs/go-ipfs-cmds#38

@Stebalien
Copy link
Member

Bundled in #4453

@Stebalien Stebalien closed this Dec 12, 2017
@ghost ghost removed the status/in-progress In progress label Dec 12, 2017
@Stebalien Stebalien deleted the fix/add-panic-ctrl-d-2 branch February 28, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sending SIGINT to ipfs repo verify incorrectly reports verify complete when daemon isn't running
3 participants