Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: support system-wide plugins #4244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

plugin: support system-wide plugins #4244

wants to merge 2 commits into from

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Sep 17, 2017

Closes #4238.

I'm not exactly sure how to wire it to up sharness, cc @Kubuxu.

Kubuxu
Kubuxu reviewed Sep 17, 2017
View reviewed changes
Rules.mk Outdated Show resolved Hide resolved
Kubuxu
Kubuxu reviewed Sep 17, 2017
View reviewed changes
cmd/ipfs/Rules.mk Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/global-plugins branch from 40df1a5 to 9c753a4 Compare September 17, 2017 22:15
@magik6k magik6k force-pushed the feat/global-plugins branch 2 times, most recently from dedc5ed to fa98b75 Compare September 25, 2017 23:03
@magik6k
Copy link
Member Author

magik6k commented Sep 26, 2017

Got sharness to work, cc @Kubuxu

Kubuxu
Kubuxu reviewed Sep 26, 2017
View reviewed changes
test/sharness/Rules.mk Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/global-plugins branch from fa98b75 to 4afb769 Compare October 13, 2017 12:59
@ghost ghost assigned magik6k Oct 13, 2017
@ghost ghost added the status/in-progress In progress label Oct 13, 2017
@magik6k magik6k force-pushed the feat/global-plugins branch from 4afb769 to 4fee1b4 Compare October 13, 2017 13:34
@magik6k magik6k added status/ready Ready to be worked and removed status/in-progress In progress labels Oct 13, 2017
Kubuxu
Kubuxu requested changes Oct 16, 2017
View reviewed changes
cmd/ipfs/Rules.mk Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/global-plugins branch from 4fee1b4 to cdbfbb4 Compare October 17, 2017 14:10
@ghost ghost added the status/in-progress In progress label Oct 17, 2017
@magik6k magik6k requested a review from Kubuxu November 1, 2017 17:12
@magik6k magik6k force-pushed the feat/global-plugins branch from cdbfbb4 to afafbdb Compare November 19, 2017 01:54
@magik6k
Copy link
Member Author

magik6k commented Nov 19, 2017

Rebased on latest master

@magik6k
plugin: support system-wide plugins
0c92a77 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
plugin: add sharness tests
5fae9a4 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k magik6k force-pushed the feat/global-plugins branch from afafbdb to 5fae9a4 Compare January 25, 2018 16:51
@magik6k
Copy link
Member Author

magik6k commented Mar 30, 2018

So this is potentially broken as it may try to load the preloaded plugins twice, with #4806 this should be easy to fix nicely

@magik6k magik6k added status/blocked Unable to be worked further until needs are met and removed status/ready Ready to be worked status/in-progress In progress labels Mar 30, 2018
@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog and removed status/blocked Unable to be worked further until needs are met labels Dec 18, 2018
@Stebalien
Copy link
Member

@magik6k I've rebased and merged the linked PR.

@Stebalien Stebalien mentioned this pull request Mar 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System-wide plugins
3 participants
@magik6k @Stebalien @Kubuxu