mount: ensure a private key is loaded before mounting /IPNS/ #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyrusleeping I've added this to RC. @thomas-gardner can you try to write a test case for that? |
|
@thomas-gardner can you try to write a test case for that?
Sure.
|
Spinning up a daemon with `--mount --offline` was leading to a nil-pointer dereference because offline routing doesn't load a private key. License: MIT Signed-off-by: Thomas Gardner <[email protected]>
|
For purpose of RC we decided not to introduce these changes, instead we blocked out We plan allowing this flag combination to work in future version. |
whyrusleeping
added
need_tests
need/author-input
Kubuxu
added
status/deferred
|
The fork no longer exists which screws up Jenkins. Please reopen with fixed sign-offs. If author doesn't respond in a week, anyone please feel free to recreate functionality of this PR. Ref for Jenkins bug https://issues.jenkins-ci.org/browse/JENKINS-41246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinning up a daemon with
--mount --offlinewas leading to anil-pointer dereference because offline routing doesn't load a private
key.
License: MIT
Signed-off-by: Thomas Gardner [email protected]