Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically download and run migrations if needed #2939

Merged
merged 7 commits into from
Jul 22, 2016
Merged

Automatically download and run migrations if needed #2939

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3bd3bc
Automatically download and run migrations if needed
whyrusleeping Jul 1, 2016
2db7522
make dist path overrideable
whyrusleeping Jul 6, 2016
cc73137
add migrate flag to daemon subcommand
whyrusleeping Jul 6, 2016
37673c8
add a test for auto migrations cli interface
whyrusleeping Jul 6, 2016
8a8730f
repo: detect OS variant, for now only linux-musl
Jul 10, 2016
fd732d2
hardcode in dists page path
whyrusleeping Jul 19, 2016
fcc4f00
move prompt code into daemon.go
whyrusleeping Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repo/fsrepo/migrations/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"strings"
)

var DistPath = "https://ipfs.io/ipns/dist.ipfs.io"
var DistPath = "https://ipfs.io/ipfs/QmUnvqDuRyfe7HJuiMMHv77AMUFnjGyAU28LFPeTYwGmFF"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this need a migration usable by 0.4.3(-*)? ? i dont think this has the last migration needed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has fs-repo-migrations-1.1.0 which includes the 3-to-4 migration: https://github.com/ipfs/fs-repo-migrations/tree/v1.1.0


func init() {
if dist := os.Getenv("IPFS_DIST_PATH"); dist != "" {
Copy link
Member

@jbenet jbenet Jul 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be a variable, not an env var. env vars are really pernicious as is. but added here that this control the distribution updates, rough!

the issue with env vars and why they're really bad for security is that it can turn secure scripts and commands into something unexpected by running before. meaning, in something like this:

> ./something
...
> /secure/bin/ipfs daemon --yes-run-migrations

something may not have been secured to not download anything, doesnt have permissions to change binaries or anything, but it can change an env var. it adds attach surface area in ways an option does not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though i think this is irrelevant if the hashes are hard coded.

Expand Down