Skip to content

Commit

Permalink
Merge pull request #3734 from ipfs/feat/keystore/list-self
Browse files Browse the repository at this point in the history
keystore: add self key to the listing
  • Loading branch information
whyrusleeping authored Mar 2, 2017
2 parents 1ef5ecb + fe0cc96 commit 57e4e21
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 4 additions & 2 deletions core/commands/keystore.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var KeyGenCmd = &cmds.Command{
Tagline: "Create a new keypair",
},
Options: []cmds.Option{
cmds.StringOption("type", "t", "type of the key to create"),
cmds.StringOption("type", "t", "type of the key to create [rsa, ed25519]"),
cmds.IntOption("size", "s", "size of the key to generate"),
},
Arguments: []cmds.Argument{
Expand Down Expand Up @@ -160,7 +160,9 @@ var KeyListCmd = &cmds.Command{

sort.Strings(keys)

list := make([]KeyOutput, 0, len(keys))
list := make([]KeyOutput, 0, len(keys)+1)

list = append(list, KeyOutput{Name: "self", Id: n.Identity.Pretty()})

for _, key := range keys {
privKey, err := n.Repo.Keystore().Get(key)
Expand Down
6 changes: 6 additions & 0 deletions test/sharness/t0165-keystore.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ test_key_cmd() {
test_expect_success "both keys show up in list output" '
echo bazed > list_exp &&
echo foobarsa >> list_exp &&
echo self >> list_exp
ipfs key list | sort > list_out &&
test_cmp list_exp list_out
'
Expand All @@ -30,6 +31,11 @@ test_key_cmd() {
ipfs key list -l | grep $edhash > /dev/null &&
ipfs key list -l | grep $rsahash > /dev/null
'

test_expect_success "key list -l contains self key with peerID" '
PeerID="$(ipfs config Identity.PeerID)"
ipfs key list -l | grep "$PeerID self"
'
}

test_key_cmd
Expand Down

0 comments on commit 57e4e21

Please sign in to comment.