consolidate dns resolver constructors

The current convention is to return the concrete type instead of an interface so let's go with that and have one constructor. License: MIT Signed-off-by: Steven Allen <[email protected]>
ipfs · May 9, 2018 · 1ff835b · 1ff835b
1 parent 5f3eb87
commit 1ff835b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/namesys/dns.go b/namesys/dns.go
@@ -21,13 +21,7 @@ type DNSResolver struct {
 }
 
 // NewDNSResolver constructs a name resolver using DNS TXT records.
-func NewDNSResolver() Resolver {
-	return &DNSResolver{lookupTXT: net.LookupTXT}
-}
-
-// newDNSResolver constructs a name resolver using DNS TXT records,
-// returning a resolver instead of NewDNSResolver's Resolver.
-func newDNSResolver() resolver {
+func NewDNSResolver() *DNSResolver {
 	return &DNSResolver{lookupTXT: net.LookupTXT}
 }
 

diff --git a/namesys/namesys.go b/namesys/namesys.go
@@ -35,7 +35,7 @@ type mpns struct {
 func NewNameSystem(r routing.ValueStore, ds ds.Datastore, cachesize int) NameSystem {
 	return &mpns{
 		resolvers: map[string]resolver{
-			"dns":      newDNSResolver(),
+			"dns":      NewDNSResolver(),
 			"proquint": new(ProquintResolver),
 			"dht":      NewRoutingResolver(r, cachesize),
 		},