coreapi pubsub: fix review nits

License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
ipfs · Sep 26, 2018 · 1facb7b · 1facb7b
1 parent a232340
commit 1facb7b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/core/commands/pubsub.go b/core/commands/pubsub.go
@@ -84,6 +84,9 @@ This command outputs data in the following encodings:
 		discover, _ := req.Options["discover"].(bool)
 
 		sub, err := api.PubSub().Subscribe(req.Context, topic, options.PubSub.Discover(discover))
+		if err != nil {
+			return err
+		}
 		defer sub.Close()
 
 		if f, ok := res.(http.Flusher); ok {

diff --git a/core/coreapi/interface/pubsub.go b/core/coreapi/interface/pubsub.go
@@ -38,7 +38,6 @@ type PubSubAPI interface {
 	Ls(context.Context) ([]string, error)
 
 	// Peers list peers we are currently pubsubbing with
-	// TODO: WithTopic
 	Peers(context.Context, ...options.PubSubPeersOption) ([]peer.ID, error)
 
 	// Publish a message to a given pubsub topic