Fix: Add daemon arg to docker run in dockeripfs plugin.
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `daemon` to the end of the `docker run` args whenever the user passes in `<ipfs-args>` to `iptb start -- <ipfs-args>`. Without this additional argument, the IPFS daemon logs a deprecation warning. We don't want to pass `daemon` into `docker run` when the user hasn't provided additional args, because `docker run` has default args when nothing else is passed. For more info, see: - ipfs/kubo#3573 - ipfs/kubo#3685 License: MIT Signed-off-by: David Grisham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
daemonto the end of thedocker runargs whenever the user passes in<ipfs-args>toiptb start -- <ipfs-args>. Without this additional argument, the IPFS daemon logs a deprecation warning:We don't pass
daemonintodocker runwhen the user hasn't provided additional args, becausedocker runhas default args when nothing else is passed.For more info, see the PRs listed in the log output: