This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: pass Retry-After to end user #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Mar 6, 2023
Comment on lines
+73
to
+74
| if errors.Is(err, &gateway.ErrorResponse{}) || | ||
| errors.Is(err, &gateway.ErrorRetryAfter{}) { |
There was a problem hiding this comment.
ℹ️ this removes the need for listing every error code
hacdias
reviewed
Mar 6, 2023
hacdias
force-pushed
the
feat/pass-http-retry-after-header
branch
from
87ef286 to
476ffb6
Compare
hacdias
reviewed
Mar 8, 2023
Comment on lines
+87
to
+94
| // (Saturn) errors that support the RetryAfter interface need to be converted | ||
| // to the correct gateway error, such that the HTTP header is set. | ||
| for v := err; v != nil; v = errors.Unwrap(v) { | ||
| if r, ok := v.(interface{ RetryAfter() time.Duration }); ok { | ||
| return gateway.NewErrorRetryAfter(err, r.RetryAfter()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks very hacky, but I love it. Now we support all errors that export the RetryAfter() time.Duration interface.
hacdias
approved these changes
Mar 8, 2023
|
I added a test so I am confident that the conversion works. I will merge once CI is green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to use cooldown and seturn it in
Retry-Afterheader to the client.Based on ipfs/boxo#194