Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 44a49a8
This pull request refactors several modules in the FsAutoComplete.Core project to use the
FSharpSymbolUse
type and theFsToolkit.ErrorHandling
library, which simplify the code and improve the error handling logic. It also removes some unused or redundant code, and adds an equality override for theHash
type.🤖 Generated by Copilot at 44a49a8
🔄🧹🛠️
WHY
Just delegating to FsToolkit for this stuff now
HOW
🤖 Generated by Copilot at 44a49a8
asyncMaybe
computation expression withasyncOption
fromFsToolkit.ErrorHandling
library for more consistent and convenient handling of optional values in async workflows (link, link, link, link, link, link, link, link, link, link, link, link, link, link)Equals
method to theHash
type inFileSystem.fs
to implement equality comparison forIFSACSourceText
values (link)FsToolkit.ErrorHandling
library inUnionPatternMatchCaseGenerator.fs
to use theasyncOption
computation expression and other utilities for error handling in F# (link)MaybeBuilder
andAsyncMaybeBuilder
types and themaybe
andasyncMaybe
values from theUtils
module, and removed theasyncMaybe
andmaybe
values from theString
module, as they were replaced by theoption
andasyncOption
values from theFsToolkit.ErrorHandling
library (link, link)ProcessHelper
module inUtils.fs
and theList
module inUtils.fs
(link, link)