Prevented an $ionicPopup race condition. #3294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the cause of this issue is if you make several popups before promises get run each will see an empty popupStack and retain the backdrop, but when closing only the last will think it's alone and release it. |
|
I'm not certain what the $timeout call was for, so I left it alone. I suspect someone more in the know could probably remove it to simplify the code. |
|
popup has had sufficient work since this one that I'm not sure this is still needed. Closing for now, let me know if you think it should be opened again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix an issue I've encountered where posting several popups at once doesn't properly release the backdrop.
I believe this is related to #3131.