feat($ionicSideMenuDelegate): add isOpen() method

Closes #1074. Closes #1075.
ionic-team · Apr 7, 2014 · 518e54e · 518e54e
1 parent dfbb376
commit 518e54e
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/js/controllers/sideMenuController.js b/js/controllers/sideMenuController.js
@@ -117,7 +117,7 @@
     },
 
     isOpen: function() {
-      return this.getOpenRatio() == 1;
+      return this.getOpenAmount() !== 0;
     },
 
     /**

diff --git a/js/ext/angular/src/directive/ionicSideMenu.js b/js/ext/angular/src/directive/ionicSideMenu.js
@@ -85,6 +85,12 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
    * opened/opening, and between 0 and -1 if right menu is opened/opening.
    */
   'getOpenRatio',
+  /**
+   * @ngdoc method
+   * @name $ionicSideMenuDelegate#isOpen
+   * @returns {boolean} Whether either the left or right menu is currently opened.
+   */
+  'isOpen',
   /**
    * @ngdoc method
    * @name $ionicSideMenuDelegate#isOpenLeft

diff --git a/test/unit/controllers/sideMenuController.unit.js b/test/unit/controllers/sideMenuController.unit.js
@@ -104,6 +104,25 @@ describe('SideMenuController', function() {
     expect(ctrl.getOpenPercentage()).toEqual(0);
   });
 
+  it('should isOpen', function() {
+    expect(ctrl.isOpen()).toEqual(false);
+    ctrl.toggleLeft();
+    expect(ctrl.isOpen()).toEqual(true);
+    ctrl.toggleLeft();
+    expect(ctrl.isOpen()).toEqual(false);
+    ctrl.toggleLeft();
+    expect(ctrl.isOpen()).toEqual(true);
+    ctrl.toggleLeft();
+
+    expect(ctrl.isOpen()).toEqual(false);
+    ctrl.toggleRight();
+    expect(ctrl.isOpen()).toEqual(true);
+    ctrl.toggleRight();
+    expect(ctrl.isOpen()).toEqual(false);
+    ctrl.toggleRight();
+    expect(ctrl.isOpen()).toEqual(true);
+  });
+
   it('should isOpenLeft', function() {
     expect(ctrl.isOpenLeft()).toEqual(false);
     ctrl.toggleLeft();
-Original file line number
+Diff line change
@@ Expand Up / @@ -117,7 +117,7 @@ @@
         },
         isOpen: function() {
-          return this.getOpenRatio() == 1;
+          return this.getOpenAmount() !== 0;
         },
         /**
@@ Expand Down @@