Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crashlytics): convert internal API usage to modular #8354

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix(crashlytics): convert internal API usage to modular #8354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/crashlytics/lib/handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*
*/

import { firebase } from '@react-native-firebase/app';
import { isError, once } from '@react-native-firebase/app/lib/common';
import { getAnalytics, logEvent } from '@react-native-firebase/analytics';
import tracking from 'promise/setimmediate/rejection-tracking';
import StackTrace from 'stacktrace-js';

Expand Down Expand Up @@ -96,7 +96,8 @@

// Notify analytics, if it exists - throws error if not
try {
await firebase.app().analytics().logEvent(
await logEvent(

Check warning on line 99 in packages/crashlytics/lib/handlers.js

View check run for this annotation

Codecov / codecov/patch

packages/crashlytics/lib/handlers.js#L99 

Added line #L99 was not covered by tests
getAnalytics(),
'app_exception', // 'app_exception' is reserved but we make an exception for JS->fatal transforms
{
fatal: 1, // as in firebase-android-sdk
Expand Down
Loading